Fix GH-11086: FPM: config test runs twice in daemonised mode #13357
Conversation
The previous check for STDERR did not work so this fixes it
|
I'm targeting just master as duplicated logging is not such a big issue and some users might even relay on it. It is also something that I found so it might not even bother anyone. |
There was a problem hiding this comment.
LGTM
Unfortunately I did not come up with a better way than checking the source file name which might not be always reliable and cover all case - specifically when there is a link to stderr. We could probably check a link (readlink) in such case and compare but it seems quite unlikely that anyone would use that - we can do it if anyone complains
I agree that just looking at the filename is probably enough in this context
|
I merged it PHP-8.3 as well at the end as I think it's a low risk and it's a bug. Not that important for 8.2 though. |
The previous check for STDERR did not work because it never actually gets
STDERR_FILENObut new file descriptor which is greater than 2. Unfortunately I did not come up with a better way than checking the source file name which might not be always reliable and cover all case - specifically when there is a link to stderr. We could probably check a link (readlink) in such case and compare but it seems quite unlikely that anyone would use that - we can do it if anyone complains. I have been also tryingisattybut that does not work if FPM is executed by script (specifically it does not work in our test env).